Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize the routes path #23

Merged
merged 1 commit into from
May 3, 2023
Merged

Normalize the routes path #23

merged 1 commit into from
May 3, 2023

Conversation

AngusMorton
Copy link
Contributor

Closes: #22

Using path.posix.relative is not an option because it returns the wrong paths on Windows. See:

It doesn't look like we have any CI, it might be worth using Github Actions and running tests on windows and ubuntu runners to catch issues like this in the future?

@AngusMorton
Normalize the path to the routes.d.ts file
785fd15 
Using path.posix.relative is not an option because it returns the wrong path.
See:
* nodejs/node#13887
* nodejs/node#13738
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 2, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: AngusMorton / name: Angus (785fd15)

@AngusMorton AngusMorton changed the title Normalize the path to the routes.d.ts file Normalize the routes path May 2, 2023
@rturnq rturnq merged commit 82ed1a1 into marko-js:main May 3, 2023
@rturnq
Copy link
Contributor

rturnq commented May 3, 2023

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

routes.d.ts file path changes when a project is rebuilt between Windows and Mac OS
2 participants
@AngusMorton @rturnq